Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(propagation): remove redundant warning messages #13220

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented Jun 17, 2024

Summary

The propagation module logs some redundant warning messages that are already printed, when necessary, during schema validation, with logic that also checks the "old default" value. This commit removes the unnecessary messages.

Checklist

  • (no) The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • (no) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4744

The propagation module logs some redundant warning messages that are
already printed, when necessary, during schema validation, with logic
that also checks the "old default" value. This commit removes the
unnecessary messages.
@bungle bungle merged commit 8b6186c into master Jun 17, 2024
34 checks passed
@bungle bungle deleted the fix/remove-redundant-propagation-warnings branch June 17, 2024 15:39
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

locao pushed a commit that referenced this pull request Jun 21, 2024
The propagation module logs some redundant warning messages that are
already printed, when necessary, during schema validation, with logic
that also checks the "old default" value. This commit removes the
unnecessary messages.

(cherry picked from commit 8b6186c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/tracing size/S
Projects
None yet
4 participants