Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.6.x] fix(plugins): add realm to removed fields #13195

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Jun 11, 2024

Manual backport of #13042 to release/3.6.x due to the fact that the original PR fixed basic-auth and key-auth but key-auth changes were introduced in newer (3.7) version.

Original description

Summary

Basic-auth and key-auth added new field "realm" but it was not added to "removed_fields" which breaks backwards compat between new CPs and old DPs. Adding realm to removed fields fixes the issue.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4516

Basic-auth added new field "realm" but it was not added to "removed_fields" which
breaks backwards compat between new CPs and old DPs.

KAG-4516

(cherry picked from commit 420b3b6)
@nowNick nowNick marked this pull request as ready for review June 11, 2024 15:01
@samugi samugi merged commit cd3e5c8 into release/3.6.x Jun 11, 2024
29 checks passed
@samugi samugi deleted the backport-13042-to-release/3.6.x branch June 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants