Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release/3.5.x] fix(aws-lambda): aws lambda service cache by service related fields (#11805) #11821

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Oct 24, 2023

Backport from #11805

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

  • fix(aws-lambda): aws lambda service cache by service related fields

  • tests(aws-lambda): add test for checking service cache refresh when vault rotates

  • style(*): lint

Fix KAG-2832

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

…11805)

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

* fix(aws-lambda): aws lambda service cache by service related fields

* tests(aws-lambda): add test for checking service cache refresh when vault rotates

* style(*): lint

Fix KAG-2832
@windmgc windmgc merged commit d775467 into release/3.5.x Oct 24, 2023
28 checks passed
@windmgc windmgc deleted the backport-aws-service-cache-fix branch October 24, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants