Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): aws lambda service cache by service related fields #11805

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Oct 23, 2023

Summary

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • aws lambda service cache by service related fields

Issue reference

Fix KAG-2832

@windmgc windmgc force-pushed the fix-aws-service-cache branch from 365f3b6 to 8cb41c8 Compare October 23, 2023 02:44
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 23, 2023
@windmgc windmgc added this to the 3.5.0 milestone Oct 23, 2023
@windmgc windmgc merged commit 8b0a838 into master Oct 23, 2023
29 checks passed
@windmgc windmgc deleted the fix-aws-service-cache branch October 23, 2023 09:17
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.5.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.5.x release/3.5.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.5.x
# Create a new branch
git switch --create backport-11805-to-release/3.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b0a8381ecf07732f8788cc14c7743a6e8bc5dd7
# Push it to GitHub
git push --set-upstream origin backport-11805-to-release/3.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.5.x

Then, create a pull request where the base branch is release/3.5.x and the compare/head branch is backport-11805-to-release/3.5.x.

windmgc added a commit that referenced this pull request Oct 24, 2023
…11805)

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

* fix(aws-lambda): aws lambda service cache by service related fields

* tests(aws-lambda): add test for checking service cache refresh when vault rotates

* style(*): lint

Fix KAG-2832
windmgc added a commit that referenced this pull request Oct 24, 2023
…11805)

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

* fix(aws-lambda): aws lambda service cache by service related fields

* tests(aws-lambda): add test for checking service cache refresh when vault rotates

* style(*): lint

Fix KAG-2832
windmgc added a commit that referenced this pull request Nov 2, 2023
…11805)

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

* fix(aws-lambda): aws lambda service cache by service related fields

* tests(aws-lambda): add test for checking service cache refresh when vault rotates

* style(*): lint

Fix KAG-2832
windmgc added a commit that referenced this pull request Nov 3, 2023
…11805)

Cache the aws lambda service by composing a cache key using the service related fields, so that service object can be reused between plugins and vault refresh can take effect when key/secret is rotated

* fix(aws-lambda): aws lambda service cache by service related fields

* tests(aws-lambda): add test for checking service cache refresh when vault rotates

* style(*): lint

Fix KAG-2832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants