Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): adopt new entity lists with KTableData #309

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat(*): adopt new entity lists with KTableData #309

merged 1 commit into from
Oct 17, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Sep 29, 2024 •
edited
Loading

Summary

Now all KTable instances are replaced with KTableData in public-ui-components. This PR adopts this change.

Issue reference

KM-551

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review October 17, 2024 07:57
Justineo
Justineo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Justineo Justineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 833acd5 into main Oct 17, 2024
19 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/adopt-new-entity-lists branch October 17, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

@sumimakito sumimakito sumimakito approved these changes

@Justineo Justineo Justineo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leopoldthecoder @Justineo @sumimakito @raoxiaoyan