Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit custom url in S3 adapter #569

Open
incyclum opened this issue Apr 23, 2018 · 3 comments
Open

Permit custom url in S3 adapter #569

incyclum opened this issue Apr 23, 2018 · 3 comments
Assignees

Comments

@incyclum
Copy link

incyclum commented Apr 23, 2018

AWS S3 URL is hardcoded in the adapter (I can't set my own URL)
so we can't use any other S3 API-compatible solutions
like Minio, Wasabi or Backblaze B2.

After adding Minio to my development stack I was impeded
because of that issue.

@nicolasmure
Copy link
Contributor

Hello :)

Thank you for pointing that out 👍
Do you mind to create a PR for that ? eg having an abstract class for all S3 API compatibles services ?
Or more flexible : set the base URL in the constructor of the S3 API compatible adapter ?

@incyclum
Copy link
Author

I'll try to take a look soon when i'll have time to work on it, i'll create a PR or write about any impediments that might occur.

@fatso83
Copy link

fatso83 commented Dec 2, 2021

@incyclum Did you ever get to this? Trying to move from the Amazon S3 adapter to the AWS S3 adapter and hitting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants