From 16c7b826f23d3cb386ffc5636e786ce45cd2abe5 Mon Sep 17 00:00:00 2001 From: charminULTRA Date: Sun, 25 Feb 2024 17:43:42 -0500 Subject: [PATCH 1/5] Update Measuring_Resonances.md Current command, using the *, results in bad chart output when more than one .csv file exists in the tmp folder. This isn't obvious for people who may not know that the * is a wildcard character. I was pulling out my hair trying to understand my results until I realized my multiple runs of data were all being used in the same graph! --- docs/Measuring_Resonances.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Measuring_Resonances.md b/docs/Measuring_Resonances.md index d1d998941dac..17d1cde8299d 100644 --- a/docs/Measuring_Resonances.md +++ b/docs/Measuring_Resonances.md @@ -450,7 +450,7 @@ TEST_RESONANCES AXIS=Y ``` This will generate 2 CSV files (`/tmp/resonances_x_*.csv` and `/tmp/resonances_y_*.csv`). These files can be processed with the stand-alone -script on a Raspberry Pi. To do that, run the following commands: +script on a Raspberry Pi. To do that, run the following commands (WARNING: Do not run these commands when there is more than one .csv file in your tmp folder. This will result in ALL files being used for the charted results): ``` ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_x_*.csv -o /tmp/shaper_calibrate_x.png ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_y_*.csv -o /tmp/shaper_calibrate_y.png From da80a1716865620a530ab4926ece06603708a5e7 Mon Sep 17 00:00:00 2001 From: charminULTRA Date: Mon, 18 Mar 2024 16:31:56 -0400 Subject: [PATCH 2/5] Editied version Sign-off by Jonathan Williams --- docs/Measuring_Resonances.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/Measuring_Resonances.md b/docs/Measuring_Resonances.md index 17d1cde8299d..cd7fde467427 100644 --- a/docs/Measuring_Resonances.md +++ b/docs/Measuring_Resonances.md @@ -450,7 +450,10 @@ TEST_RESONANCES AXIS=Y ``` This will generate 2 CSV files (`/tmp/resonances_x_*.csv` and `/tmp/resonances_y_*.csv`). These files can be processed with the stand-alone -script on a Raspberry Pi. To do that, run the following commands (WARNING: Do not run these commands when there is more than one .csv file in your tmp folder. This will result in ALL files being used for the charted results): +script on a Raspberry Pi. This script is intended to be run with a single CSV +file for each axis measured, although it can be used with multiple CSV files +if you desire to average the results of different resonance tests. To run the +processing script, execute the following commands: ``` ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_x_*.csv -o /tmp/shaper_calibrate_x.png ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_y_*.csv -o /tmp/shaper_calibrate_y.png From 77dd55e74455abf83fa74c33de345cd8a748797c Mon Sep 17 00:00:00 2001 From: charminULTRA Date: Mon, 18 Mar 2024 16:34:26 -0400 Subject: [PATCH 3/5] Fix trailing spaces Sign-off by Jonathan Williams --- docs/Measuring_Resonances.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Measuring_Resonances.md b/docs/Measuring_Resonances.md index cd7fde467427..f68b86657018 100644 --- a/docs/Measuring_Resonances.md +++ b/docs/Measuring_Resonances.md @@ -452,7 +452,7 @@ This will generate 2 CSV files (`/tmp/resonances_x_*.csv` and `/tmp/resonances_y_*.csv`). These files can be processed with the stand-alone script on a Raspberry Pi. This script is intended to be run with a single CSV file for each axis measured, although it can be used with multiple CSV files -if you desire to average the results of different resonance tests. To run the +if you desire to average the results of different resonance tests. To run the processing script, execute the following commands: ``` ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_x_*.csv -o /tmp/shaper_calibrate_x.png From 01f3ea8dd2327f0a5232448bd93bfa2a1f5e6fe6 Mon Sep 17 00:00:00 2001 From: charminULTRA Date: Thu, 25 Apr 2024 20:00:03 -0400 Subject: [PATCH 4/5] Sign-off by Jonathan Williams jcw122@gmail.com --- docs/Measuring_Resonances.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/Measuring_Resonances.md b/docs/Measuring_Resonances.md index f68b86657018..f4b0492acac9 100644 --- a/docs/Measuring_Resonances.md +++ b/docs/Measuring_Resonances.md @@ -450,10 +450,11 @@ TEST_RESONANCES AXIS=Y ``` This will generate 2 CSV files (`/tmp/resonances_x_*.csv` and `/tmp/resonances_y_*.csv`). These files can be processed with the stand-alone -script on a Raspberry Pi. This script is intended to be run with a single CSV -file for each axis measured, although it can be used with multiple CSV files -if you desire to average the results of different resonance tests. To run the -processing script, execute the following commands: +script on a Raspberry Pi. This script is intended to be run with a single CSV +file for each axis measured, although it can be used with multiple CSV files +if you desire to average the results. Averaging results can be useful, for +example, if resonance tests were done at multiple test points. Delete the extra +CSV files if you do not desire to average them. ``` ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_x_*.csv -o /tmp/shaper_calibrate_x.png ~/klipper/scripts/calibrate_shaper.py /tmp/resonances_y_*.csv -o /tmp/shaper_calibrate_y.png From eaf516c432caa6ca6139f1af7ae284a2ad0dbad6 Mon Sep 17 00:00:00 2001 From: charminULTRA Date: Thu, 25 Apr 2024 20:11:12 -0400 Subject: [PATCH 5/5] Update Sign-off by Jonathan Williams jcw122@gmail.com --- docs/Measuring_Resonances.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/Measuring_Resonances.md b/docs/Measuring_Resonances.md index f4b0492acac9..ca7d0cc77747 100644 --- a/docs/Measuring_Resonances.md +++ b/docs/Measuring_Resonances.md @@ -450,9 +450,9 @@ TEST_RESONANCES AXIS=Y ``` This will generate 2 CSV files (`/tmp/resonances_x_*.csv` and `/tmp/resonances_y_*.csv`). These files can be processed with the stand-alone -script on a Raspberry Pi. This script is intended to be run with a single CSV -file for each axis measured, although it can be used with multiple CSV files -if you desire to average the results. Averaging results can be useful, for +script on a Raspberry Pi. This script is intended to be run with a single CSV +file for each axis measured, although it can be used with multiple CSV files +if you desire to average the results. Averaging results can be useful, for example, if resonance tests were done at multiple test points. Delete the extra CSV files if you do not desire to average them. ```