Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Creating room and adding users #14

Open
MahirMahdi opened this issue Jan 31, 2023 · 6 comments
Open

Fix: Creating room and adding users #14

MahirMahdi opened this issue Jan 31, 2023 · 6 comments

Comments

@MahirMahdi
Copy link
Contributor

Properly implement room and users event.

@KlausMikhaelson
Copy link
Owner

yeah that was on the list earlier but forgot to add it, thanks for pointing it out !,
let's work on this one together !

@MahirMahdi
Copy link
Contributor Author

No worries. Yes sure, I would love to work together. 😀

@MahirMahdi
Copy link
Contributor Author

Here's how I've implemented creating room and users events. Let me know if we need to change anything. 😀

Screenshot 2023-02-01 074942

Screenshot 2023-02-01 075022

Screenshot 2023-02-01 075652

Screenshot 2023-02-01 075718

@KlausMikhaelson
Copy link
Owner

Hey @MahirMahdi absolutely loved this !, can you create a draft pr for the same ?

@MahirMahdi
Copy link
Contributor Author

Yes sure! On it.

@KlausMikhaelson
Copy link
Owner

@MahirMahdi Hey mahir so sorry was stuck somewhere and forgot to come back to this one but thank you so much for working on it will check it out today and so sorry for not responding for a long time lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants