Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsdelivr for CDN #378

Open
thewtex opened this issue Feb 18, 2021 · 4 comments
Open

Use jsdelivr for CDN #378

thewtex opened this issue Feb 18, 2021 · 4 comments
Assignees

Comments

@thewtex
Copy link
Member

thewtex commented Feb 18, 2021

https://www.jsdelivr.com/

Appears to be more production-oriented than Unpkg

@thewtex
Copy link
Member Author

thewtex commented Mar 31, 2022

Local testing works, need to update doc's.

@thewtex
Copy link
Member Author

thewtex commented May 18, 2022

@PaulHax with #485 does the CDN bundle still work? Can it be updated to use jsdelivr?

@thewtex thewtex assigned PaulHax and unassigned bnmajor May 18, 2022
@PaulHax
Copy link
Collaborator

PaulHax commented May 18, 2022

#485 does not change the publicPath for the itkVtkViewerCDN.js webpack target... But how to mock a jsdeliver setup for that branch?

You already setup webpack to use jsdeliver methinks...

@thewtex
Copy link
Member Author

thewtex commented May 19, 2022

You already setup webpack to use jsdeliver methinks...

Hmm, it seems so. 🙄 Good job past me :-).

I see we have __itk_version__:

imageIOUrl: __webpack_public_path__ + 'itk-image-io@' + __itk_version__, // eslint-disable-line no-undef
meshIOUrl: __webpack_public_path__ + 'itk-mesh-io@' + __itk_version__, // eslint-disable-line no-undef

But in recent itk-wasm, we are decoupling the itk-*-io package version from the main itk-wasm package. So, I will keep this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants