Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silent failure in signWin.js #4582

Open
pierremtb opened this issue Nov 26, 2024 · 5 comments · May be fixed by #4762
Open

Silent failure in signWin.js #4582

pierremtb opened this issue Nov 26, 2024 · 5 comments · May be fixed by #4762
Assignees
@pierremtb
Labels
packaging For all things about packaging the app.

Comments

@pierremtb
Copy link
Collaborator 

Signing using signWin.js script: failed: Error: Command failed: smctl sign --fingerprint="***" --input "D:\a\modeling-app\modeling-app\out\__uninstaller-nsis-zoo-modeling-app.exe"

See https://github.com/KittyCAD/modeling-app/actions/runs/12035958661/job/33556399180#step:11:67

Found during #4581
@pierremtb pierremtb added the packaging For all things about packaging the app. label Nov 26, 2024
@pierremtb pierremtb self-assigned this Nov 26, 2024
@pierremtb
Copy link
Collaborator Author

This happened between v27 and v28. Cannot reproduce on v27, shows verified publisher

v0.27.0...v0.28.0#diff-522ae163e12dad85c62f150dfabcdb30e90e96baca0a54d16c69ac4532c15fcaR167 shows no env var change during the change to the new build process

@pierremtb
Copy link
Collaborator Author

None of the recent nightly builds have the failure in the logs https://github.com/KittyCAD/modeling-app/actions?query=event%3Aschedule

@pierremtb
Copy link
Collaborator Author

Latest nightly build (v24.11.26) runs well on windows

@pierremtb
Copy link
Collaborator Author

Retrying the job on windows again to see if we see the 403 https://github.com/KittyCAD/modeling-app/actions/runs/12035958661

@pierremtb
Copy link
Collaborator Author

https://github.com/KittyCAD/modeling-app/actions/runs/12035958661/job/33560283646 all 'successful' after retry

@pierremtb pierremtb mentioned this issue Nov 26, 2024
Closed
pierremtb added a commit that referenced this issue Dec 11, 2024
@pierremtb
WIP: Silent failure in signWin.js
b5b03cf 
Fixes #4582
@pierremtb pierremtb linked a pull request Dec 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierremtb pierremtb

Labels
packaging For all things about packaging the app.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Silent failure in signWin.js KittyCAD/modeling-app
1 participant
@pierremtb