Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.28.0 #4581

Closed
pierremtb opened this issue Nov 26, 2024 · 17 comments
Closed

Cut release v0.28.0 #4581

pierremtb opened this issue Nov 26, 2024 · 17 comments
Assignees

Comments

@pierremtb
Copy link
Collaborator

pierremtb commented Nov 26, 2024

Follow process at https://github.com/KittyCAD/modeling-app?tab=readme-ov-file#release-a-new-version

@pierremtb pierremtb self-assigned this Nov 26, 2024
@pierremtb
Copy link
Collaborator Author

https://github.com/KittyCAD/modeling-app/actions/runs/12035098773 is running based on tag v0.28.0 on 4423ae1

@pierremtb
Copy link
Collaborator Author

@franknoirot
Copy link
Collaborator

franknoirot commented Nov 26, 2024

Manual test tasklist for MacOS

  • Double clicking a KCL file opens ZMA.
    • One note is that trying this on a file in my ~/code directory resulted in a freeze. However, doing the same with a file in a sub-directory of my ~/code directory worked fine.
  • The application opens
  • User can sign in
  • A project can be created
  • A sketch can be draw (line, arc, rect, circle).
  • Lines and shapes can be modified.
  • Select face and extruding works.
  • Reloading the application reloads the sketch.
  • Can create additional files and directories.
  • Models can be exported to a file.
  • I repeated some code done with point-and-click by typing in the code editor and everything was responsive and ok.
  • The auto-updater works.

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 26, 2024

Manual test tasklist for Windows

  • The application opens
  • User can sign in
  • A project can be created
  • A sketch can be draw (line, arc, rect, circle).
  • Lines and shapes can be modified.
  • Select face and extruding works.
  • Reloading the application reloads the sketch.
  • Can create additional files and directories.
  • Models can be exported to a file.
  • Double clicking a KCL file opens ZMA.
  • I repeated some code done with point-and-click by typing in the code editor and everything was responsive and ok.
  • The auto-updater works.

Note: I ran into a windows smartscreen 'run anyway' dialog when installing the build, which is suspicous. Need to look into that before releasing

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 26, 2024

Manual test tasklist for Linux

  • The application opens
  • User can sign in
  • A project can be created
  • A sketch can be draw (line, arc, rect, circle).
  • Lines and shapes can be modified.
  • Select face and extruding works.
  • Reloading the application reloads the sketch.
  • Can create additional files and directories.
  • Models can be exported to a file.
  • I repeated some code done with point-and-click by typing in the code editor and everything was responsive and ok.
  • Double clicking a KCL file opens ZMA.
  • The auto-updater works.

Notes:

  • the icon shows up with appimaged installed
  • double clicking doesn't work cause we don't file associate by default I think on linux but right click - open with - ZMA worked!

@pierremtb
Copy link
Collaborator Author

Recreating the tag, as @franknoirot pointed out the tag wasn't pointing to 4423ae1 as intended but to an early v28 tag I had created for testing a few days ago

@pierremtb
Copy link
Collaborator Author

https://github.com/KittyCAD/modeling-app/actions/runs/12035958661 is the new workflow to track for testing

@pierremtb
Copy link
Collaborator Author

Resetting the list above for Linux

@pierremtb
Copy link
Collaborator Author

Ready for testing again

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 26, 2024

Note: I ran into a windows smartscreen 'run anyway' dialog when installing the build, which is suspicious. Need to look into that before releasing. Not blocking but unsettling.

Image

@pierremtb
Copy link
Collaborator Author

Also checked updated, looked good on windows

@pierremtb
Copy link
Collaborator Author

Well I'm not getting the smartscreen dialog with v27 (instead getting 'verified publisher'). Definitely a regression on windows codesign between v27 and v28. Need to investigate

@pierremtb
Copy link
Collaborator Author

https://github.com/KittyCAD/modeling-app/actions/runs/12035958661/job/33560283646 attempt number 2 showing 'successful' on codesign steps for windows compared to the first one. I deleted the v0.28.0 draft release so that the script can recreate it with the new builds. Let's see

@pierremtb
Copy link
Collaborator Author

https://github.com/KittyCAD/modeling-app/releases/tag/untagged-4be34d798fdb857be91f got recreated :)

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 26, 2024

Proposed changelog:

Changed

  • KCL:
    • Object literals like {x} as shorthand for {x = x}
    • Executor returns specific errors, not anyhow
    • Add patternTransform2d for sketches
    • Allow transform patterns to return multiple transforms
    • Record initialization (AKA objects) uses = instead of :, as in { x = 0, y = 1 }
    • Implicit conversion of round numbers to integers
    • Add round stdlib function
    • Add tangentToEnd stdlib function
  • Selections Refactor

Added

  • Offset plane point-and-click user flow
  • Nightly link in the About section
  • Warnings for recently deprecated syntax

Fixed

  • Selection bugs
  • Enter sketch mode bug
  • Argument error to point to the arg at the call site

Full Changelog: v0.27.0...v0.28.0

@pierremtb
Copy link
Collaborator Author

Things that went wrong today:

  1. I tagged the wrong commit at first (I had a local tag already from last week testing) 🤦
  2. Silent codesign flake on windows that caused smartscreen warnings on smoke tests, need to make sure it fails loudly next time so we can catch it much earlier Silent failure in signWin.js #4582
  3. The publish-apps-release workflow didn't trigger as intended, had to manually delete and recreate the release to work around a bot-triggering-bot GHA limitation. New issue at Update release process to trigger publish-apps-release properly #4586
  4. Testing path still in the publish-apps-release workflow instead of the prod one, already fixed on main Fix publish path in release bucket #4585
  5. Curly braces without backticks in the release notes, which caused the website to delay rendering, thanks @franknoirot for debugging this. Working on it now.

@pierremtb
Copy link
Collaborator Author

https://zoo.dev/modeling-app/download now has v28 links and changelog. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants