Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapList / toggleList eliminates nodes it shouldn't? #35

Open
riosn-n opened this issue May 21, 2019 · 1 comment
Open

wrapList / toggleList eliminates nodes it shouldn't? #35

riosn-n opened this issue May 21, 2019 · 1 comment
Labels
bug report unconfirmed bug report

Comments

@riosn-n
Copy link

riosn-n commented May 21, 2019

If the container of the list is inside another block node, the behavior of wrapList seems incorrect. If, for example, your schema looks like section -> paragraph -> unordered-list. Calling wrapList when the cursor is in the paragraph will eliminate the entire section node.

@brendancarney brendancarney added the bug report unconfirmed bug report label May 22, 2019
@mmdonaldson
Copy link

What's the suggested fix for this? Wouldn't it need to be implemented in the users codebase? E.g. in my editor that i implement this plugin I would need to update my schema to allow for un ordered and ordered lists inside section and/or paragraph @riosn-n ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report unconfirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants