Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example on slate-code is not working properly #28

Open
isubasti opened this issue Mar 29, 2019 · 3 comments
Open

example on slate-code is not working properly #28

isubasti opened this issue Mar 29, 2019 · 3 comments
Labels
documentation good first issue Good for newcomers

Comments

@isubasti
Copy link

the onKeyDown example on slate-code's doc only return next() inside the ctrlKey check therefore some keys are not handled properly see https://slate-js.slack.com/archives/C1RH7AXSS/p1553824026021400
@brendancarney brendancarney added the bug confirmed bug label Apr 2, 2019
@brendancarney
Copy link
Collaborator

Thanks for the report @isubasti, I'll look into this soon.

@brendancarney
Copy link
Collaborator

I'm unable to reproduce this issue. I asked the reporter in slack for a CodeSandbox to reproduce.

@brendancarney brendancarney added bug report unconfirmed bug report documentation and removed bug confirmed bug bug report unconfirmed bug report labels Apr 8, 2019
@brendancarney
Copy link
Collaborator

Ah, just confirmed that this is a documentation issue. The example in the docs doesn't call next() when it should. We probably need an else block for when ctrlKey is not pressed.

@brendancarney brendancarney added the good first issue Good for newcomers label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendancarney @isubasti