Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar not updated, when month is switched #2

Closed
rmrustem opened this issue Jun 5, 2017 · 3 comments · May be fixed by #18
Closed

Calendar not updated, when month is switched #2

rmrustem opened this issue Jun 5, 2017 · 3 comments · May be fixed by #18

Comments

@rmrustem
Copy link
Contributor

rmrustem commented Jun 5, 2017

When a month is changed, e.g. from May 31 to June 1, the calendar stays on May 31 for several days.

See https://forum.magicmirror.builders/topic/238/monthly-calendar/22
rmrustem pushed a commit to rmrustem/calendar_monthly that referenced this issue Jun 5, 2017
issue KirAsh4#2 fixed: calendar not updated when month is switched
3a41ecd
KirAsh4 added a commit that referenced this issue Jul 8, 2017
@KirAsh4
Merge pull request #3 from rmrustem/master
9df377e 
issue #2 fixed: calendar not updated when month is switched
KirAsh4 added a commit that referenced this issue Jul 8, 2017
@KirAsh4
Revert "issue #2 fixed: calendar not updated when month is switched"
7e52316
KirAsh4 added a commit that referenced this issue Jul 8, 2017
@KirAsh4
Merge pull request #4 from KirAsh4/revert-3-master
ffd705a 
Revert "issue #2 fixed: calendar not updated when month is switched"
@KirAsh4
Copy link
Owner

KirAsh4 commented Jul 8, 2017

I managed to carve some time for this and had hoped I can merge it easily but immediately discovered another problem with the refresh rate as I stated in the reverted commit message. I'll take a closer look at it and work out a fix for the end of the month issue. Feel free to resubmit a fix if you manage to get to one before me.

@KirAsh4 KirAsh4 closed this as completed Jul 8, 2017
@d-Rickyy-b
Copy link

Hi there. I am still having the same issue. Has this been fixed? The status is unclear to me from just this issue.

@d-Rickyy-b
Copy link

Hi @KirAsh4 - I would highly appreciate a fix for this issue. Could you take some time to have another look at it?

d-Rickyy-b added a commit to d-Rickyy-b/calendar_monthly that referenced this issue Feb 10, 2020
@d-Rickyy-b
fix: remove unnecessary check for midnight
7b942d6 
The check if moment() > this.midnight is not necessary.
getDom should always get the dom, no matter what time it is. This is also one reason why the issue KirAsh4#2 exists. Also this commits changes some strange usages of moment() and removes  unused code.
@d-Rickyy-b d-Rickyy-b mentioned this issue Feb 10, 2020
Open
htilburgs added a commit to htilburgs/MMM-MyMonthlyCalendar that referenced this issue Jun 21, 2023
@htilburgs
Update MMM-MyMonthlyCalendar.js
41374a2 
fix: remove unnecessary check for midnight
The check if moment() > this.midnight is not necessary.
getDom should always get the dom, no matter what time it is. This is also one reason why the issue KirAsh4#2 exists. Also this commits changes some strange usages of moment() and removes  unused code.

Author: d-Rickyy-b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: calendar not updating on month change d-Rickyy-b/calendar_monthly
3 participants
@rmrustem @KirAsh4 @d-Rickyy-b