Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox does not respect ThemeManager theme #631

Open
dostjh opened this issue Nov 29, 2023 · 2 comments
Open

NumberBox does not respect ThemeManager theme #631

dostjh opened this issue Nov 29, 2023 · 2 comments

Comments

@dostjh
Copy link

dostjh commented Nov 29, 2023

I implemented NumberBox in my application that is set up to work in Dark Mode. However, NumberBox did not respect the theme.

Specifying ThemeManager.RequestedTheme on the control itself can be used as a workaround.

Bug
<ui:NumberBox Header="Clients to start" Value="{Binding NumberOfClientsToStart, Mode=TwoWay}" InputScope="Number" SpinButtonPlacementMode="Inline" Text="Clients to start"/>
image

Workaround
<ui:NumberBox Header="Clients to start" Value="{Binding NumberOfClientsToStart, Mode=TwoWay}" InputScope="Number" SpinButtonPlacementMode="Inline" Text="Clients to start" ui:ThemeManager.RequestedTheme="Dark"/>
image

@TomHedwig
Copy link

I met the same problem. @dostjh
Additionally, VS would prompt a binding error like that:

Severity Count Data Context Binding Path Target Target Type Description
Error 1 null Fill GeometryDrawing.Brush Brush Cannot find governing FrameworkElement or FrameworkContentElement for target element.

@dostjh
Copy link
Author

dostjh commented Oct 31, 2024

This appears to also happen for TextBlock elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants