Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceSet is interpreted incorrectly if no data is specified #14

Open
Siebje opened this issue Jan 21, 2022 · 1 comment
Open

TraceSet is interpreted incorrectly if no data is specified #14

Siebje opened this issue Jan 21, 2022 · 1 comment

Comments

@Siebje
Copy link
Contributor

Siebje commented Jan 21, 2022

To reproduce:

  • Create an empty trace set with the header containing only
    Header.TRS_VERSION: 2
  • Try to open the trace set

Expected:

  • The trace set can be opened

Actual:
[ERROR] 13:59:31 FIPy base_request_handler.py:_handle_request_exception:43 | Traceback (most recent call last):
[...]
File "\trsfile\engine\trs.py", line 301, in get_traces
parameters = self.read_parameter_data()
File "\trsfile\engine\trs.py", line 323, in read_parameter_data
parameters['LEGACY_DATA'] = ByteArrayParameter(data)
File "\trsfile\traceparameter.py", line 23, in init
raise ValueError('The value for a TraceParameter cannot be empty')

@Siebje
Copy link
Contributor Author

Siebje commented Jan 21, 2022

This seems to be caused by the fact that no TraceParameterDefinitionMap is present in the provided header. However, I would expect that in this case an empty definition map is created automatically if TRS_VERSION 2 is specified,

@aickerso aickerso added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants