Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader considers certain files as stop points #13

Closed
QueenOfRodents opened this issue Oct 29, 2024 · 2 comments · May be fixed by #32
Closed

Reader considers certain files as stop points #13

QueenOfRodents opened this issue Oct 29, 2024 · 2 comments · May be fixed by #32

Comments

@QueenOfRodents
Copy link

I'm not entirely sure whether it is due to an unoptimized file, but I have noted that MIDI Processor would specifically treat a certain file of mine as a "stop" rather than converting it or past it. Specifically, whenever I would try to convert one of my midis in particular, it would not convert it, and would actually consider it a break point. No files placed after it would be converted, and if put as the only file/top of the file, nothing would be generated. I have tested it and have realized it is specifically this file, no others caused it.

I do have the link to the file in question, and I am not experienced at all with editing MIDIs, but I would like to know what causes this. The link to the file is: https://songs.bardmusicplayer.com/?dl=1153668247397343353. If this is an issue that is easily fixed or has been asked before, I apologize.

Thank you for your time.

@Zephira58
Copy link

Zephira58 commented Nov 16, 2024

Heyaaaaa, so it was just a mild incompatibility with the way the midi was created as far as i was able to tell, i had encountered the same bug you did.

Tweaked it a tiny amount in fl studio (how you create and edit midi files) and re-exported it to an amazing success~! I've gone ahead and attached the updated midi, and converted files for you here, if that's everything feel free to mark the issue as closed and hopefully it helps!

(btw, you dont need to convert them anymore but just thought i'd do it to help you out)
(Ayla Storm) Scatman - Scatmans World.zip

Zephira58 added a commit to Zephira58/WEBFISHING-Guitar-Player that referenced this issue Nov 16, 2024
Closes: KevAquila#13
Adds a song a user was having issues with, which should also close their issue, as the application will ship with the new song
Zephira58 added a commit to Zephira58/WEBFISHING-Guitar-Player that referenced this issue Nov 16, 2024
Fix: song name

just made it index the same in the playlist by changing the name to match the existing example

Add: Bastille - Pompeii

Add: Captainsparklez - Fallen Kingdom

ingame user request :3

Add: Scatman

Closes: KevAquila#13
Adds a song a user was having issues with, which should also close their issue, as the application will ship with the new song

Remove: Duplicate Songs

There's some songs which are duplicates of others, I've removed them to save space and make it easier to identify which song should be played.

Add: I see the light, Broken dreams

Their both pretty popular and i think people would want to play them

FIx: Midi encoding

Accidentally pushed the wrong branch last time, this one should have all the updated information correctly <3

Fix: Updated midi encoding

Manually tweaked some of the midi files using FL Studio to play a bit better. And added the correct file extension for all of the songs for compatibility
Zephira58 added a commit to Zephira58/WEBFISHING-Guitar-Player that referenced this issue Nov 16, 2024
commit 219ab5e
Author: Zephira <[email protected]>
Date:   Fri Nov 15 01:50:43 2024 +1030

    Add: more meme songs

    Fix: song name

    just made it index the same in the playlist by changing the name to match the existing example

    Add: Bastille - Pompeii

    Add: Captainsparklez - Fallen Kingdom

    ingame user request :3

    Add: Scatman

    Closes: KevAquila#13
    Adds a song a user was having issues with, which should also close their issue, as the application will ship with the new song

    Remove: Duplicate Songs

    There's some songs which are duplicates of others, I've removed them to save space and make it easier to identify which song should be played.

    Add: I see the light, Broken dreams

    Their both pretty popular and i think people would want to play them

    FIx: Midi encoding

    Accidentally pushed the wrong branch last time, this one should have all the updated information correctly <3

    Fix: Updated midi encoding

    Manually tweaked some of the midi files using FL Studio to play a bit better. And added the correct file extension for all of the songs for compatibility
@QueenOfRodents
Copy link
Author

Hell yeah, you're the best! Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants