Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widows: ytarchive freezes terminal UI (cannot select etc.) when running #232

Open
fireattack opened this issue Nov 27, 2024 · 3 comments
Open

Comments

@fireattack
Copy link

fireattack commented Nov 27, 2024

This is technically a regression (it worked fine before), but the regression happened a very long time ago. I just never bothered to report it.

The issue:

Whenever ytarchive runs (downloading or waiting. Just print version will not), it freezes the terminal (tested: CMD, PowerShell, both native and within Windows Terminal) window UI in that you cannot select text, right click to call context menu, etc.

For Windows Terminal, thankfully it only freezes the current tab, not the entire thing.

Furthermore, for native CMD and PowerShell window, I by default enable "Quick Edit Mode" (so you can select directly). Using ytarchive to download or wait a valid URL will somehow disable this mode, even after you interruptted and exited ytarchive.

Version: ytarchive 0.4.0-68e1bf9
Node.js v20.5.1

@Kethsar
Copy link
Owner

Kethsar commented Nov 27, 2024

even after you interruptted and exited

Hmm, is that doing a hard-interrupt without letting it exit gracefully? Disabling quick-edit mode was a "feature" someone else asked I put in because clicking the terminal in that mode causes it to appear frozen, and was confusing a lot of users that accidentally did so.

@fireattack
Copy link
Author

yes, doing a hard-interrupt (ctrl+C)

@fireattack
Copy link
Author

fireattack commented Nov 27, 2024

Disabling quick-edit mode was a "feature" someone else asked I put in

That explains it. But can we disable this (no idea how though since we don't have config file AFAIK. An argument maybe?)? I understand it may confuse people who isn't familiar with CLI tools but that's just the default behavior of CMD/Terminal, and not be able to copy is annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants