New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete list of valid arguments #27

Open

nferrari opened this issue Jul 31, 2015 · 0 comments

nferrari commented Jul 31, 2015

In some places, a verification is done to know if the user is providing valid arguments. I think the lists have some arguments names missing:

While creating a Check, I got a warning about the "tags" argument but it works.
https://github.com/KennethWilke/PingdomLib/blob/master/pingdomlib/check.py#L66

While updating a Check, I got a warning about the "name" argument but it works.
https://github.com/KennethWilke/PingdomLib/blob/master/pingdomlib/check.py#L356

I don't know if these missing arguments are the only one, that's why I can't yet provide a PR. If you think I can make one with only these 2, I will.

Regards,

jcshort mentioned this issue

'name' missing from check __setattr__ whitelist #29

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment