-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webbrowser.get() can hang and should be timeouted #1259
Comments
Thanks for shedding light on this issue. Upgrading to Commander v16.11.3 or higher should fix it. |
I don't think this will fix it as 6d15bdb as you will never go out from line 264 |
From my own testing, |
I'm not entirely sure what that script is supposed to show. |
@aaunario-keeper exactly, there are problems with dbus on WSL and https://github.com/alyptik/dotfiles/blob/2c3d5a5c9886e998042ea4eee21097241a65a890/xdg-settings#L465 for testing purpose I replaced whole script with sleep but it's hanging on the line I pasted here |
https://github.com/Keeper-Security/Commander/blob/fe9c026e600f6d60cc636e30ae1546436df18d03/keepercommander/auth/console_ui.py#L264C18-L264C28
webbrowser.get() under some circumstances (my case is WSL2 and wslu from Flox) can hang indefinetelly on xdg-settings:
xdg-settings get default-web-browser
will just not return anythingThis will render UI blank until interrupted with "ctrl+c", then normal keeper UI proceeds
There are multiple issues (e.g microsoft/WSL#8892) touching the subject on the topic but I believe timeouting it will be easiest as there is an Exception catcher there anyway.
The text was updated successfully, but these errors were encountered: