Fixes #38113 - Add a link to REX bootc job templates in image mode details card. #11272
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lfu
force-pushed
the
link_rex_templates
branch
from
1adbc6f to
f24d38c
Compare
|
Some reason, when I click the link it's sending me just to the "Run job" screen with nothing filled out:
I do get sent to this endpoint though: |
|
Have you run in rails console: |
ianballou
reviewed
Jan 8, 2025
| @@ -28,6 +34,7 @@ const ImageModeCard = ({ isExpandedGlobal, hostDetails }) => { | |||
| masonryLayout | |||
| isExpandedGlobal={isExpandedGlobal} | |||
| > | |||
| <a href={actionUrl(hostDetails.name)}>{__('Bootc action template')}</a> | |||
There was a problem hiding this comment.
I think using "template" is a little confusing for users, perhaps we can find a title that better describes the relationship to running bootc actions on the host:
Suggested change
| <a href={actionUrl(hostDetails.name)}>{__('Bootc action template')}</a> | |
| <a href={actionUrl(hostDetails.name)}>{__('Modify via remote execution')}</a> |
There was a problem hiding this comment.
@jeremylenz you mentioned having some potential input too :)
There was a problem hiding this comment.
Right, I was thinking Run bootc action maybe? but actually I like this better!
lfu
force-pushed
the
link_rex_templates
branch
from
f24d38c to
894c248
Compare
jeremylenz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Host - Details - Image mode details