Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in propensity calculations and a method that takes a model and evaluates its performance at time 0 #93

Open
artgoldberg opened this issue May 11, 2020 · 1 comment
Assignees

Comments

@artgoldberg
Copy link
Contributor

See email to Yin Hoon 2020/05/11:

Based on the traceback your model is here in the stack:

wc_sim/submodels/nrm.py:initialize_propensities()
wc_sim/submodels/dynamic_submodel.py:calc_reaction_rates()

and then in some eval() method(s) in wc_sim/dynamic_components.py

First, that code doesn’t generate logging messages, so I’ll add some.
Second, it’s possible that a small number of the rate laws are taking most of the time. In that case we need to identify them and determine how to reduce their compute time.
Third, we’d like to solve this problem without waiting many hours or days for results. Ideally we’d make a test that iterates through all rate law calculations, skipping ones that take too long, and creates a list of those.
There are ways to do that, but it needs to be built into wc-sim. Perhaps it needs an initial_performance_eval method that takes a model and evaluates its performance at time 0.

@artgoldberg artgoldberg self-assigned this May 11, 2020
@artgoldberg
Copy link
Contributor Author

Did "Add logging in propensity calculations"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant