Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance RunResults #70

Closed
artgoldberg opened this issue Nov 7, 2019 · 4 comments
Closed

Enhance RunResults #70

artgoldberg opened this issue Nov 7, 2019 · 4 comments

Comments

@artgoldberg
Copy link
Contributor

artgoldberg commented Nov 7, 2019

These to_hdf() calls in __init__() raise the warnings:

random_states_s.to_hdf(self._hdf_file(), 'random_states')
metadata_s.to_hdf(self._hdf_file(), 'metadata')

The warning is:

/usr/local/lib/python3.6/site-packages/pandas/core/generic.py:1996 PerformanceWarning:
your performance may suffer as PyTables will pickle object types that it cannot
map directly to c-types [inferred_type->mixed,key->values] [items->None]
@artgoldberg artgoldberg changed the title Address performance warning raised by pandas/io/pytables in wc_sim/run_results.py Enhance RunResults Dec 8, 2019
@artgoldberg
Copy link
Contributor Author

Also:

  • Have hdf use disk more efficiently; for unknown reasons, in one example hdf uses 4.4M to store the data in 52 pickle files of 8K each, more than 10x less efficient than pickle.
  • Speedup convert_checkpoints(), which runs slowly.
  • Test all methods that take compartment id in a model with multiple compartments.

@artgoldberg
Copy link
Contributor Author

did: make get_concentrations() work for all compartments

@artgoldberg
Copy link
Contributor Author

master 9494ce9 did "Speedup convert_checkpoints(), which runs slowly"

@artgoldberg
Copy link
Contributor Author

Finished, except for a couple of issues copied to #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant