Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for syntax highlighting support for named arguments in PHP 8 #7

Open
alexr00 opened this issue May 23, 2023 · 3 comments · May be fixed by #12
Open

Request for syntax highlighting support for named arguments in PHP 8 #7

alexr00 opened this issue May 23, 2023 · 3 comments · May be fixed by #12
Labels
bug Something isn't working

Comments

@alexr00
Copy link

alexr00 commented May 23, 2023

Description

Please support syntax highlighting for named arguments in PHP 8. Currently, the feature/token is detected as constant.other.php, making it difficult to distinguish named arguments from constants.

Steps to Reproduce

<?php declare(strict_types=1);

#[Attribute(name:'attribute')]
function foobar()
{
    throw new RuntimeException(message:'Exception', code:1);
}

Please support syntax highlighting for named arguments in PHP 8. Currently, the feature/token is detected as constant.other.php, making it difficult to distinguish named arguments from constants.

Originally from @asispts in microsoft/vscode#183181

@alexr00
Copy link
Author

alexr00 commented May 23, 2023

@KapitanOczywisty thank you for taking on the PHP grammar for VS Code!

@KapitanOczywisty KapitanOczywisty added the enhancement New feature or request label May 23, 2023
@BladeMF
Copy link

BladeMF commented Oct 30, 2023

image This seems fixed?

@BladeMF
Copy link

BladeMF commented Oct 30, 2023

Actually constructors are not working currently.

@BladeMF BladeMF linked a pull request Oct 30, 2023 that will close this issue
@KapitanOczywisty KapitanOczywisty added bug Something isn't working and removed enhancement New feature or request labels Oct 30, 2023
@KapitanOczywisty KapitanOczywisty linked a pull request Oct 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants