Stepstick Lookup Table and Config Options #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwnance
previously approved these changes
Jul 18, 2024
rogerlz
reviewed
Jul 18, 2024
|
Current state of this: |
YanceyA
reviewed
Jul 22, 2024
YanceyA
reviewed
Jul 22, 2024
YanceyA
reviewed
Jul 23, 2024
YanceyA
reviewed
Jul 23, 2024
|
I think this is good, just need someone else to test |
lraithel15133
force-pushed
the
tmclookuprebase
branch
from
912b359 to
906b372
Compare
rogerlz
force-pushed
the
tmclookuprebase
branch
from
906b372 to
65d1a22
Compare
miklschmidt
reviewed
Oct 29, 2024
| | Stepstick Type | Config Name | Sense Resistor | Max Current | | ||
| |-----------------------------------------|-------------------------|----------------|-------------| | ||
| | BTT Kraken S1-4 | KRAKEN_2160_8A | 0.022 | 8 | | ||
| | BTT Kraken S5-8 | KRAKEN_2160_3A | 0.022 | 3 | |
There was a problem hiding this comment.
These (5-8) use the default 0.075 ohm sense resistor.
miklschmidt
reviewed
Oct 29, 2024
| "REFERENCE_2209": (0.11, 2), | ||
| "REFERENCE_5160": (0.075, 3), | ||
| "KRAKEN_2160_8A": (0.022, 8), | ||
| "KRAKEN_2160_3A": (0.022, 3), |
miklschmidt
reviewed
Oct 29, 2024
| "config", | ||
| f"""Neither 'stepper_driver_type' or 'sense_resistor' is defined for [{self.name}]. | ||
| Using default value of {self.sense_resistor} ohm sense resistor. | ||
| If this is incorrect, your drivers or board may be damaged.""", |
There was a problem hiding this comment.
drivers, steppers or board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #325
This PR adds a lookup table for known stepsticks (more will be added as time goes on), some logic for a new config option called 'stepstick_type', and documentation on the logic.
Heres the rundown:
If sense_resistor is defined: use it with full priority, no exceptions
else if stepstick_type is defined: use its lookup table value for sense_resistor
else use tmc default and warn user
if stepstick_type is defined: use its max_current value
else use tmc default
While I agree we should not have defaults set for configuration options like this, I also am not a fan of breaking everyones configs at this state in the project.