Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in firmware retract #204

Closed
richfelker opened this issue Apr 9, 2024 · 2 comments
Closed

Regressions in firmware retract #204

richfelker opened this issue Apr 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@richfelker
Copy link

Idempotency of the G10 and G11 commands is an important/key property of firmware-retract. It's what makes it so your start gcode can end in a retracted state (so it doesn't ooze and lose priming) even if your slicer (cough Cura) insists on performing its own retraction before the initial travel move, without getting a double-retract.

Maintaining statefulness of retraction after one print ends and before another begins is also important to keep filament retracted at the right point not to ooze or waste excess material priming the next print.

The changes in https://github.com/DangerKlippers/danger-klipper/pull/83 make the former spam warnings, and completely break the latter by clearing retraction state after each print. They should be reverted and the system for introducing Z-hop re-thought not to break existing firmware-retraction semantics.

@rogerlz
Copy link
Contributor

rogerlz commented Apr 10, 2024

Thanks for the feedback. We are working on making the features from #83 optional and returning the default behaviour for users that prefer so until we can work on a better solution

https://github.com/DangerKlippers/danger-klipper/pull/206

@rogerlz
Copy link
Contributor

rogerlz commented Nov 22, 2024

#420 is waiting for feedback

@rogerlz rogerlz closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants