chore: fixed all the minor Clippy rants #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirushik
force-pushed
the
kirushik/code_quality_improvements
branch
from
2aec22f to
5ba7f4d
Compare
|
I still find https://github.com/Alzymologist/Kalatori-backend/blob/5ba7f4db5faad3baff183058eaf88ee6856a2c0b/src/database.rs#L316-L325 and https://github.com/Alzymologist/Kalatori-backend/blob/5ba7f4db5faad3baff183058eaf88ee6856a2c0b/src/rpc.rs#L466-L488 suspicious, and would've preferred this would be a more concise logic. Consumer asked for |
|
we can merge #12 first to make sure this passes; branch protection rules are not set yet. |
Slesarew
approved these changes
Mar 4, 2024
Slesarew
changed the title
|
Is this redundant with #18? |
|
ok it is deprecated I suppose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for #12 being merged