Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat#5 voiceroom list #14

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Feat#5 voiceroom list #14

merged 3 commits into from
Jul 10, 2024

Conversation

YangJJune
Copy link
Contributor

@YangJJune YangJJune commented Jul 10, 2024 •
edited by Turtle-Hwan
Loading

Summary

보이스룸 목록 view를 제작하였습니다.

image

피그마의 해당 화면

#5

PR 유형 및 세부 작업 내용

  • 새로운 기능 추가

작동 스크린샷

chrome-capture-2024-7-9

의견

현재 useState가 구현될만한 부분(보이스룸 리스트 등)은 API도 확실하게 나오지 않았고 공부도 부족하여 임시로 해놓은 상황. 향후 수정 예정

YangJJune added 2 commits July 9, 2024 16:02
@YangJJune
Update package-lock.json
544681e
@YangJJune
add VoiceRoomListPage
dbbb6ea 
with test code of Homepage.tsx
add route in App.tsx
@Turtle-Hwan Turtle-Hwan self-requested a review July 10, 2024 10:32
@Turtle-Hwan Turtle-Hwan added Feat New feature or request Style css, style labels Jul 10, 2024
This was linked to issues Jul 10, 2024
[FEAT] 보이스룸 #4
Open
보이스룸 목록 view 제작 #5
Closed
Turtle-Hwan
Turtle-Hwan requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Turtle-Hwan Turtle-Hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Turtle-Hwan
Copy link
Member

Turtle-Hwan commented Jul 10, 2024 •
edited
Loading

작동 스크린샷에는 bottom nav bar가 보이는데 올라온 코드엔 없는 것 같아요.

혹시 지금 만들고 계신건가요?

다음에 이 브랜치에서 코드 수정하기 전에 git pull 함 해주시고 하면 됩니다

@Turtle-Hwan Turtle-Hwan merged commit ce1938a into main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turtle-Hwan Turtle-Hwan Turtle-Hwan approved these changes

Assignees

@YangJJune YangJJune

@Turtle-Hwan Turtle-Hwan

Labels
Feat New feature or request Style css, style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 보이스룸 보이스룸 목록 view 제작
2 participants
@YangJJune @Turtle-Hwan