Compile under macOS #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this helped me compile this for macOS |
|
While I'm not opposed to merging this, is there any particular reason this is being proposed here and not to the upstream repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
436bdb8 removed OSX project files back in 2014.
However, it's really easy to compile this project for macOS using the current Makefile. This PR adds a Darwin check to the makefile as
unamedoesn't have a-ooption on macOS. Once this check is in place,makecompiles the project with no warnings. This PR also adds a quickBUILDING.mdthat currently documents how to build on macOS.