Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS overrides timeWarpRates from BetterTimeWarp at startup #305

Open
kretze opened this issue Sep 27, 2024 · 8 comments
Open

RSS overrides timeWarpRates from BetterTimeWarp at startup #305

kretze opened this issue Sep 27, 2024 · 8 comments

Comments

@kretze
Copy link

kretze commented Sep 27, 2024

Is there a way to have RSS not set its warp rates when BetterTimeWarpContinued is installed?

When KSP is started, default values ​​of RSS are always set.

image

You have to activate the BetterTimeWarpContinued warp profile every time you start the game. If you forget this and exit ksp, the profile will be overwritten with the rss warp values.

image

@kretze
Copy link
Author

kretze commented Sep 28, 2024

This topic was already discussed at BetterTimewarpContinued in 2023. But nothing could be done there.
linuxgurugamer/BetterTimeWarpContinued#33

Additionally, I now remember that RP-1 recommends “BetterTimeWarp” in the additional mods (Wiki). But that's not good if it doesn't work completely.

@siimav
Copy link

siimav commented Sep 28, 2024

After every scene change RSS replaces the timewarp values with these:

timeWarpRates
{
rate1 = 10
rate2 = 100
rate3 = 1000
rate4 = 10000
rate5 = 100000
rate6 = 1000000
rate7 = 6000000
}
}

@siimav
Copy link

siimav commented Sep 28, 2024

Additionally, I now remember that RP-1 recommends “BetterTimeWarp” in the additional mods (Wiki). But that's not good if it doesn't work completely.

Want me to remove the recommendation? :)

@kretze
Copy link
Author

kretze commented Sep 28, 2024

My question is whether the TimeWarpFixer includes a way to check BetterTimeWarp/BetterTimeWarpContinued and if it is installed, whether the RSS WarpRates are no longer set.
Because it is then managed with the other mod.

if BetterTimeWarp not installed then do RSS WarpRates else do nothing

@siimav
Copy link

siimav commented Sep 28, 2024

I mean it could check whether BetterTimeWarp is installed BUT what happens if the player hasn't set up anything sane inside that mod?

@kretze
Copy link
Author

kretze commented Sep 28, 2024

BetterTimeWarp has default Warp Profiles
Standard: 5,10,50,100,1000,10000,100000
PhysicsWarp: 1,2,3,4

These are the standard profiles that are included
https://github.com/linuxgurugamer/BetterTimeWarpContinued/blob/master/GameData/BetterTimeWarp/PluginData/BetterTimeWarp_Defaults.cfg

I can also ask there whether an option for RSS is installed so that the RSS warp rates are set as standard when RSS is detected.
This could be a win-win situation for both mods. And they would be fully compatible with each other.


Unreasonable attitudes can already happen. As soon as a warp profile is active with bettertimewarp, it is currently maintained until KSP is terminated.

RSS currently only overwrites the information when I start the game. The change of scene does not change anything in conjunction with BetterTimeWarp.
I've been playing like this for a few days/weeks and just have to revise and activate the profile after starting KSP.

I once opened a post on BetterTimeWarp.
linuxgurugamer/BetterTimeWarpContinued#35

@kretze
Copy link
Author

kretze commented Sep 29, 2024

My thoughts on changing to BetterTimeWarpContinued would be:

BTWC checks whether RSS is installed. If so, an RSS parameter is set to true in the BetterTimeWarp.cfg and this means that not the normal standard warp profile is used, but an RSS standard warp profile (10, 100, 1000, 10000, 100000, 1000000, 6000000)

The further configuration for using the personal Warp Profiles is left to the user.
Not everyone wants to use such extreme warp rates.


I personally only use 10, 50, 100, 2000, 10000, 100000, 400000.
I'm so busy managing RP-1 that I've almost never used 1,000,000 and never used 6,000,000.

@kretze
Copy link
Author

kretze commented Sep 29, 2024

It would probably be better:
Whenever the standard needs to/should be set, include a query for RSS.

if RSS is installed
{ use RSS Warp Profile } else { use Standard Warp Profile }

Default: 5, 10, 50, 100, 1000, 10000, 100000
RSS Default: 10, 100, 1000, 10000, 100000, 1000000, 6000000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants