Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example config-sorting-duplicates.yaml: descriptions of what is returned #32

Open
thomas-delva opened this issue Aug 28, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request priority:medium

Comments

@thomas-delva
Copy link

thomas-delva commented Aug 28, 2020

Description

I will admit this is a nitpick, but still. In the readme the return types for the routes for the config-sorting-duplicates.yaml example do not match what is actually returned:

As far as I can tell, the sorting and duplicate removal is done correctly though.

How to reproduce

  1. Start Walder version 2.0.2 with the command yarn start -c example/config-sorting-duplicates.yaml -l debug --no-cache
  2. Surf to http://localhost:3000/music/Marcella%20Detroit/no_duplicates, http://localhost:3000/music/Marcella%20Detroit/everything_together or http://localhost:3000/artist/David%20Bowie
@pheyvaer pheyvaer self-assigned this Aug 28, 2020
@pheyvaer
Copy link
Collaborator

Regarding http://localhost:3000/artist/David%20Bowie I get the a list of URLs first and then a list of songs. Did you scroll down on the page?

@pheyvaer
Copy link
Collaborator

pheyvaer commented Oct 6, 2020

@thomas-delva Bump 😉

@thomas-delva
Copy link
Author

Yes, regarding http://localhost:3000/artist/David%20Bowie, the description is indeed correct! I read it as "song names with movie URLs" in error.

Leaving the issue open wrt the first bullet point

@pheyvaer pheyvaer added enhancement New feature or request priority:medium labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants