Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'here's in the english docs #843

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Remove 'here's in the english docs #843

merged 1 commit into from
Aug 3, 2023

Conversation

grasegger
Copy link
Contributor

@grasegger grasegger commented Aug 2, 2023 •
edited
Loading

I made some changes to hopefully close #713

@grasegger grasegger changed the title Clean up english documentation to replace 'here' with more meaningful… Remove 'here's in the english docs Aug 2, 2023
@grasegger
Copy link
Contributor Author

Somehow a strange s file made it into the commit - should I squash and force push or do you want to squash when merging?

@grasegger
Copy link
Contributor Author

I fixed a typo and forced pushed with that, so there is no need to squash anymore

xs5871
xs5871 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!
We usually squash and/or rebase before merging. But of course you're totally free to do that on your end and force push if you want.

@xs5871 xs5871 merged commit 0172d4a into KMKfw:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xs5871 xs5871 xs5871 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "here" links in the docs
2 participants
@grasegger @xs5871