Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disassembly view: allow to disable branches / jumps #516

Closed
GitMensch opened this issue Oct 6, 2023 · 1 comment · Fixed by #518
Closed

Disassembly view: allow to disable branches / jumps #516

GitMensch opened this issue Oct 6, 2023 · 1 comment · Fixed by #518
Assignees
@lievenhey
Labels
enhancement

Comments

@GitMensch
Copy link
Contributor

Here's a real-world disassembly from objdump --visualize-jumps:

grafik

As you see there's no option to actually view the disassembly in that screen...
Please provide an option to disable the jumps (maybe just move to a separate column which would make it possible to enable/disable that way and also allow to temporarily make the column smaller / large enough as needed.
lievenhey added a commit that referenced this issue Oct 10, 2023
@lievenhey
add setting to disable branches in disassembler
9f47177 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
@lievenhey lievenhey linked a pull request Oct 10, 2023 that will close this issue
Disable branches #518
Merged
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
ff5c80f 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
7207c02 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
41bda57 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
b2494e1 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
cb8083e 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
356119e 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
692e5b7 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 11, 2023
@lievenhey
add setting to disable branches in disassembler
1e74256 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 12, 2023
@lievenhey
add setting to disable branches in disassembler
582dc32 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 12, 2023
@lievenhey
add setting to disable branches in disassembler
c2a4a84 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 12, 2023
@lievenhey
add setting to disable branches in disassembler
e7c1411 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 12, 2023
@lievenhey
add setting to disable branches in disassembler
1999318 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
@GitMensch GitMensch mentioned this issue Oct 13, 2023
Closed
lievenhey added a commit that referenced this issue Oct 19, 2023
@lievenhey
add setting to disable branches in disassembler
4b8366c 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 19, 2023
@lievenhey
add setting to disable branches in disassembler
a6dd6ba 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 19, 2023
@lievenhey
add setting to disable branches in disassembler
5eb7a57 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 19, 2023
@lievenhey
add setting to disable branches in disassembler
b68e608 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 20, 2023
@lievenhey
add setting to disable branches in disassembler
564103f 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 20, 2023
@lievenhey
add setting to disable branches in disassembler
99d0f1a 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
lievenhey added a commit that referenced this issue Oct 20, 2023
@lievenhey
add setting to disable branches in disassembler
825d48b 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
milianw pushed a commit that referenced this issue Oct 21, 2023
@lievenhey @milianw
add setting to disable branches in disassembler
c682645 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
milianw pushed a commit that referenced this issue Oct 21, 2023
@lievenhey @milianw
add setting to disable branches in disassembler
99cafd6 
sometimes there are too many branches, this patch allows the user to
disable them

fixes: #516
@GitMensch GitMensch changed the title Disassembly view: allow to disable jumps Disassembly view: allow to disable branches / jumps Oct 24, 2023
@GitMensch
Copy link
Contributor Author

One (minor) last part is still open: if --visualize-jumps is not supported then the branches column should be auto-hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lievenhey lievenhey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable branches KDAB/hotspot
3 participants
@milianw @GitMensch @lievenhey