qtypes: add support for Qt alias types that don't match #904
Conversation
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e8826f5 to
e409d32
Compare
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e409d32 to
e5daff8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11949 11949
=========================================
Hits 11949 11949 ☔ View full report in Codecov by Sentry. |
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
2 times, most recently
from
debf9b7 to
79cc8fe
Compare
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
3 times, most recently
from
6a21207 to
c67af09
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
c67af09 to
709d25d
Compare
There was a problem hiding this comment.
Overall this looks good.
Naming wise I would just copy Qts casing (so lowercase). These types are quiet "fundamental types", which even in Rust are lowercase (i64, isize, etc.).
A sort-off open question is still how many operations we want to support on these...
Do we basically just enable From/Into and call it a day, or do we want to have support for using the type more directly, like support for +-*/ on qint64...
For now it's probably good enough if we just have them convertable to their inner type, but something to keep in mind.
On the same note: Maybe we don't want to support Deref on these types?
It may be weird if you call e.g. abs on qint64, but get an i64 back...
And now it would be a breaking change for us to add our own abs method that returns qint64...
So it seems like limiting the API to just From/To with some derives is maybe best?
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
709d25d to
aec4f39
Compare
Some times don't match the Rust types so add these missing types. Closes KDAB#882
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
aec4f39 to
f2bf8e6
Compare
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
f2bf8e6 to
91759c2
Compare
| @@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased](https://github.com/KDAB/cxx-qt/compare/v0.7.0...HEAD) | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Support for further types: `qreal`, `qint64`, `qintptr`, `qsizetype`, `quint64`, `quintptr` | |||
There was a problem hiding this comment.
do we also want qlonglong, qulonglong, or qptrdiff ?
See https://doc.qt.io/qt-6/qttypes.html#types for full types in Qt
There was a problem hiding this comment.
Let's just go with what we need at the moment and add new types as needed.
| @@ -35,6 +36,9 @@ mod ffi { | |||
| #[rust_name = "sibling_at_row"] | |||
| fn siblingAtRow(self: &QModelIndex, row: i32) -> QModelIndex; | |||
|
|
|||
| /// Returns a `quintptr` used by the model to associate the index with the internal data structure. | |||
| #[rust_name = "internal_id"] | |||
| fn internalId(self: &QModelIndex) -> quintptr; | |||
There was a problem hiding this comment.
Note that this is a breaking change.
However, let's do this now while we are still pre-1.0
There was a problem hiding this comment.
Of course it's the same fo all other APIs that were changed during this PR.
| @@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased](https://github.com/KDAB/cxx-qt/compare/v0.7.0...HEAD) | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Support for further types: `qreal`, `qint64`, `qintptr`, `qsizetype`, `quint64`, `quintptr` | |||
There was a problem hiding this comment.
Let's just go with what we need at the moment and add new types as needed.
Closes #882