Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cxx qt lib extras #860

Merged
merged 17 commits into from
Apr 5, 2024
Merged

Add cxx qt lib extras #860

merged 17 commits into from
Apr 5, 2024

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Feb 22, 2024

No description provided.

@Montel Montel self-assigned this Feb 22, 2024
@Montel
Copy link
Contributor Author

Montel commented Feb 22, 2024

It"s WIP.
I didn't find where we change it!

@Montel Montel marked this pull request as draft February 22, 2024 10:24
@Montel
Copy link
Contributor Author

Montel commented Feb 22, 2024

ok pb:
/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/39e351642d8689ff-qcommandlineoption.cxx.o" "-c" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen/src/qcommandlineoption.cxx.cpp" cargo:warning=src/core/qcommandlineoption.cpp:9:10: erreur fatale: ../assertion_utils.h : Aucun fichier ou dossier de ce nom cargo:warning= 9 | #include "../assertion_utils.h" cargo:warning= | ^~~~~~~~~~~~~~~~~~~~~~ cargo:warning=compilation terminée. exit status: 1 cargo:warning=ToolExecError: Command "c++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-m64" "-I" "/usr/include/qt6/QtCore" "-I" "/usr/include/qt6" "-I" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out" "-I" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen" "-Wall" "-Wextra" "-std=c++17" "-o" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/b3615968b6006c75-qcommandlineoption.o" "-c" "src/core/qcommandlineoption.cpp" with args "c++" did not execute successfully (status code exit status: 1).cargo:warning=/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen/src/qcommandlineoption.cxx.cpp:2:10: erreur fatale: cxx-qt-lib/qstring.h : Aucun fichier ou dossier de ce nom cargo:warning= 2 | #include "cxx-qt-lib/qstring.h" cargo:warning= | ^~~~~~~~~~~~~~~~~~~~~~ cargo:warning=compilation terminée.

=> we need assertion_utils.h + qstring.h so what's missing for cxx-qt-lib in extra ?

@Montel
Copy link
Contributor Author

Montel commented Feb 22, 2024

ok removing cxx-qt-lib directly
now

@Montel
Copy link
Contributor Author

Montel commented Feb 22, 2024

I hope that it uses qstring.h from cxx-qt-lib and not qt directly :)

@Montel Montel marked this pull request as ready for review February 22, 2024 14:02
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Montel
Copy link
Contributor Author

Montel commented Apr 5, 2024

What is missing for merging it ? :)

@ahayzen-kdab
Copy link
Collaborator

What is missing for merging it ? :)

I think there was only ...

  • should this go into this repo or it's own ? I think we decided it was fine here for now then later make it depend on stable releases once enough helpers exist.
  • are there any tests being run with it ? once this is in another repo the the QtWidgets examples: add basic widgets example #622 example could be used for this, for now maybe we go without and in examples: add basic widgets example #622 i could add those QtWidgets types to -extras?

So maybe we are ready?

@Montel
Copy link
Contributor Author

Montel commented Apr 5, 2024

Yep we decided to wait after 0.7 for splitting in another repo.
We decided to add tests when we will split it as it's more easy.

@ahayzen-kdab ahayzen-kdab force-pushed the add_cxx-qt-lib-extras branch from 0e608ae to c783f3e Compare April 5, 2024 08:14
@ahayzen-kdab
Copy link
Collaborator

Meanwhile what is happening to CI, seen Windows and macOS fail once with this in the Upload GitAction actions artifacts of vcpkg logs 🤔

 Error: Failed to FinalizeArtifact: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

@ahayzen-kdab
Copy link
Collaborator

Meanwhile what is happening to CI, seen Windows and macOS fail once with this in the Upload GitAction actions artifacts of vcpkg logs 🤔

 Error: Failed to FinalizeArtifact: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

I'm getting random 500 errors navigating the github website, so suspect it is related. And there is a github incident https://www.githubstatus.com/incidents/5ly0psff2s5d

@ahayzen-kdab ahayzen-kdab force-pushed the add_cxx-qt-lib-extras branch from ce20cc8 to 21723b2 Compare April 5, 2024 10:39
@Montel Montel force-pushed the add_cxx-qt-lib-extras branch from 21723b2 to 27720eb Compare April 5, 2024 10:42
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Montel Montel merged commit 9caf477 into KDAB:main Apr 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants