From 1feede1647b0c58ce84093d6b0b26f68d3f9360d Mon Sep 17 00:00:00 2001
From: Daniel Nicoletti <daniel.nicoletti@kdab.com>
Date: Fri, 22 Sep 2023 16:58:23 -0300
Subject: [PATCH] Add GitHub actions

---
 .github/workflows/build.yml | 99 +++++++++++++++++++++++++++++++++++++
 tests/launchertest.cpp      |  9 ++--
 2 files changed, 105 insertions(+), 3 deletions(-)
 create mode 100644 .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
new file mode 100644
index 0000000000..40fc92ef2a
--- /dev/null
+++ b/.github/workflows/build.yml
@@ -0,0 +1,99 @@
+# SPDX-FileCopyrightText: 2023 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
+#
+# SPDX-License-Identifier: MIT
+
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false #true
+      matrix:
+        os:
+          - ubuntu-22.04
+          #- windows-2022
+          #- macos-12
+        build_type:
+          - Debug
+          #- Release
+        qt:
+          - version: "5.15.2"
+            requested: "5.15"
+          - version: "6.3.2"  # Qt 6.3 is not an LTS version, so '6.3.*' always resolves to '6.3.2'
+            requested: "6.3.*"
+            modules: qtshadertools
+
+    steps:
+      - name: Install Qt with options and default aqtversion
+        uses: jurplel/install-qt-action@v3
+        with:
+          aqtversion: null # use whatever the default is
+          modules: ${{ matrix.qt.modules }}
+          version: ${{ matrix.qt.requested }}
+          cache: true
+
+      - name: Checkout sources
+        uses: actions/checkout@v4
+
+      - name: Create build directory
+        run: mkdir build
+
+      - name: Install ninja-build tool (must be after Qt due PATH changes)
+        uses: turtlesec-no/get-ninja@main
+
+      - name: Make sure MSVC is found when Ninja generator is in use
+        if: ${{ runner.os == 'Windows' }}
+        uses: ilammy/msvc-dev-cmd@v1
+
+      - name: Configure project
+        run: >
+          cmake -S . -B ./build -G Ninja
+          -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
+          -DGAMMARAY_BUILD_UI=${{ startsWith(matrix.qt.version, '6.') }}
+          -DGAMMARAY_BUILD_DOCS=${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+
+      - name: Build Project
+        run: cmake --build ./build
+
+      - name: Install dependencies on Ubuntu
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+        run: |
+          sudo apt update -qq
+          sudo apt install -y gdb
+
+      - name: Enable gdb attaching
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+        run: echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope
+
+        # Exclude connectiontest-style-filter is flaky
+      - name: Run tests on Linux Qt5 (offscreen)
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' && startsWith(matrix.qt.version, '5.') }}
+        run: ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure -E "connectiontest-style-filter"
+        env:
+          QT_QPA_PLATFORM: offscreen
+
+        # Exclude qmlsupporttest|bindinginspectortest for Qt6, connectiontest-style-filter is flaky
+      - name: Run tests on Linux Qt6 (offscreen)
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' && startsWith(matrix.qt.version, '6.') }}
+        run: ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure -E "qmlsupporttest|bindinginspectortest|connectiontest-style-filter"
+        env:
+          QT_QPA_PLATFORM: offscreen
+
+      - name: Run tests on Windown/macOS
+        if: ${{ matrix.build_type == 'Debug' && runner.os != 'Linux' }}
+        run: ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+
+      - name: Read tests log when it fails
+        uses: andstor/file-reader-action@v1
+        if: ${{ failure() && matrix.build_type == 'Debug' }}
+        with:
+          path: "./build/Testing/Temporary/LastTest.log"
diff --git a/tests/launchertest.cpp b/tests/launchertest.cpp
index 21b20340bc..6e0d398357 100644
--- a/tests/launchertest.cpp
+++ b/tests/launchertest.cpp
@@ -25,6 +25,7 @@
 
 #include <QDebug>
 #include <QObject>
+#include <QScopeGuard>
 #include <QSignalSpy>
 #include <QTest>
 
@@ -130,6 +131,11 @@ private slots:
     static void testAttach()
     {
         QProcess target;
+        auto cleanup = qScopeGuard([&target] {
+            target.kill();
+            target.waitForFinished();
+        });
+
         target.setProcessChannelMode(QProcess::ForwardedChannels);
         target.start(QLatin1String(TESTBIN_DIR "/minimalcoreapplication"), {}, QProcess::ReadWrite);
         QVERIFY(target.waitForStarted());
@@ -149,9 +155,6 @@ private slots:
 
         spy.wait(30000);
         QCOMPARE(spy.count(), 1);
-
-        target.kill();
-        target.waitForFinished();
     }
 };