Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorkit v0.13 #13

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Tensorkit v0.13 #13

merged 6 commits into from
Nov 5, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Nov 4, 2024

This bumps the TensorKit compatibility to v0.13.
As this does not change any functionality, I opted to only bump the minor version, as otherwise everything should be backwards compatible.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (d136b39) to head (6ec6779).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   74.13%   73.42%   -0.71%     
==========================================
  Files           5        5              
  Lines         634      621      -13     
==========================================
- Hits          470      456      -14     
- Misses        164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/stiefel.jl Outdated Show resolved Hide resolved
G = sectortype(W)
dims = TensorKit.SectorDict{G,Int}()
generator = Iterators.map(blocks(W)) do (c, b)
V = fuse(domain(W))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clever 😃 : using functions what they are meant for instead of reimplementing them 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my moments 😁

@Jutho Jutho merged commit d7e11e2 into master Nov 5, 2024
12 checks passed
@Jutho Jutho deleted the tensorkit-0.13 branch November 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants