-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similarities/Differences to the manifolds from Manifolds.jl #10
Comments
Hi @kellertuer , thanks for your interest. I agree that this package certainly has a similar goal as Manifolds.jl (but is of course much more limited). The idea is that However, such a I am definitely aware of the existence of the ecosystem of Manifolds.jl and related packages, and might have looked at it for a brief time, but it wasn't clear to me whether this kind of generalisation (where the points on the manifolds are not I am certainly open to discuss the possibilities for collaboration, as neither the manifold stuff but especially the different optimisation algorithms that are compatible with it are within my main expertise. Hence, if somehow what would be needed at our side could be supported from within Manifolds.jl, that would lighten the maintainance burden on our side, and immediately give access to many more optimisation algorithms as well potentially other manifolds that are useful in our applications. For further reference: optimisation over these manifolds is done with https://github.com/Jutho/OptimKit.jl , and these manifolds are used, not in TensorKit.jl itself, but in the packages built on top of it like https://github.com/maartenvd/MPSKit.jl and https://github.com/mhauru/MERAKit.jl . |
HI @Jutho, In Manifolds.jl we do not restrict types of points or manifolds – usually the manifold itself “decides” what it wants to accept (by multiple dispatch) and different representations of points (or phrased precisely different types) are possible for sure – for example we have 3 different point representations for hyperbolic https://juliamanifolds.github.io/Manifolds.jl/latest/manifolds/hyperbolic.html, and also the manifold itself can be any struct where you can store more information / structure. Concerning Optimisation – my main field is therein as well – since the first thing I did start was Manopt.jl ( https://manoptjl.org/stable/ ) which is exactly also optimisation manifolds. So the main point of this issue (maybe it is even more like a discussion, but these are not activated here), is whether we can maybe share certain aspects of these works / packages :) and sure, if you depend on ManifoldsBase.jl only (like Manoptjl does) you gain “free acess” to more manifolds, as well as having less work to maintain the manifolds. |
Hi,
this looks like a super interesting package – are the manifolds then used within Tensorkit?
If so, would it maybe be useful to check whether we can join forces with the following idea:
We have Stiefel and Grassmann (also generalises, complex and symplectic) variants in Manifolds.jl – so if (really just if) that would fit tensor kit as well, we could check how to maybe join forces here?
We also provide different metrics and retractions.
Would be interesting to learn whether that is a thing one can do here (though that would diminish the purpose of the package itself here).
The text was updated successfully, but these errors were encountered: