-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #98
Small fixes #98
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 80.39% 80.57% +0.18%
==========================================
Files 42 42
Lines 5432 5453 +21
==========================================
+ Hits 4367 4394 +27
+ Misses 1065 1059 -6 ☔ View full report in Codecov by Sentry. |
Looks good, although it seems one AD test still did not pass on Julia 1.6. But it seems an accuracy issue again, at least all the values that are printed seem to match with a large number of significant digits. |
I'll keep playing around a bit to see if I can get it to behave, it's probably not that important, but the green check is nice |
Especially since this will affect all further CI runs once merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there.a reason to reorganise the position of weakdeps and extensions in the Project.toml? I thought Aqua made me make exactly the opposite move in TensorOperations.jl
Ok I'll merge this and revert Project.toml changes in the final commits to #95 |
argmax(f, domain)
which is not defined in versions below 1.7