-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite constructbraidingtensor preprocessor #95
Conversation
It is still easy to break |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 80.57% 81.43% +0.85%
==========================================
Files 42 42
Lines 5453 5533 +80
==========================================
+ Hits 4394 4506 +112
+ Misses 1059 1027 -32 ☔ View full report in Codecov by Sentry. |
@Jutho : Soon I'll have some fermionic PEPS that I want to contract and not optimize. This should be a great testcase :) For now, both yours and Lukas fixes run but I don't know if the output is the correct one. |
00d1d23
to
dc552e9
Compare
When the test turn green, I think this is now ready. I have locally tested the current master of MPSKit with this on Julia 1.10, and all seems fine. Maybe there are additional tests from PEPSKit that @Gertian wants to try? |
Ok I will merge this. If there would still be issues with this in PEPSKit.jl @Gertian , let me know. |
@Jutho I'll see if my old code for contraction still works. What is the current status for AD of planar fermionic diagrams ? |
Somewhere near the top of my ever larger to-do list 😉 I'm a little hesitant to promise due dates, but maybe end of January-ish? Maybe @Jutho has more time? |
Great :) I'm happy to hear it's still on your menu ! |
Definitely still on the menu. I have a lot of grading to do the coming weeks, but if I need some distraction or procrastination, the AD rules for the planar operations might be a good candidate. However, you are also very welcome to give it a try yourself if you want :-). |
To be honest I have no idea where to get started with this. |
https://github.com/Jutho/TensorKit.jl/tree/ld/planar-ad This was a little more painful than I anticipated, but I think this could be a preliminary working version. Can you try it out? I wrote some small tests, but I can't say I am super confident about it. |
Thanks, I'll play around with it today. |
This is an alternative to PR#94, that should also be correct if you have a tensor expression composed of a sum of different tensor network contractions. I've included the test cases from PR#94.
I think also
_remove_braidingtensors
will suffer from the same bugs as the old_construct_braidingtensors
, so I probably will also rewrite this one before merging.Also, it needs some more testing and it contains a branch that should not active and currently prints out a "huh". So I should not forget to remove this.
Maybe you can already test with your code and with MPSKit: @lkdvos and @Gertian .