Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusiontree iterator with multiplicities #192

Closed
lkdvos opened this issue Dec 30, 2024 · 3 comments · Fixed by #193
Closed

Fusiontree iterator with multiplicities #192

lkdvos opened this issue Dec 30, 2024 · 3 comments · Fixed by #193

Comments

@lkdvos
Copy link
Collaborator

lkdvos commented Dec 30, 2024

While updating SUNRepresentations to the latest version of TensorKit, I ran into an issue where it seems like the fusiontree iterator is generating trees that are not allowed. To reproduce this issue, running the tests for this branch does the trick, but the following also showcases the problem (using that branch):

using SUNRepresentations, TensorKit

uncoupled = (Irrep[SU₃]((1, 0, 0)), Irrep[SU₃]((1, 1, 0)), Irrep[SU₃]((1, 0, 0)), Irrep[SU₃]((2, 1, 0)), Irrep[SU₃]((1, 0, 0)))
coupled = Irrep[SU₃]((6, 2, 0))
isdual = (false, true, true, false, true)

f = collect(fusiontrees(uncoupled, coupled, isdual))[2] # wrong vertices
Nsymbol(f.innerlines[end-1], f.uncoupled[end-1], f.innerlines[end]) # 1
f.vertices[end-1] # 2

I'm not 100% sure that the iterator is the culprit, but I checked with a couple versions of SUNRepresentations (specifically also before I changed the linear order) and the problem persists. The fusiontree iteration is definitely not something I am too familiar with though...

@Jutho
Copy link
Owner

Jutho commented Dec 30, 2024

Yes something is definitely wrong in the logic that deals with the vertices. I'll try to fix asap.

@Jutho
Copy link
Owner

Jutho commented Dec 30, 2024

Can you check if the branch jh/fixfusiontreeiterator fixes the problems? We should probably reenable SU(N) tests in the TensorKit testsuite.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Jan 1, 2025

This indeed seems to resolve the issues. I would suggest that we merge and tag this, then I'll tag the updated SUNRepresentations.jl version that depends only on TensorKitSectors.jl, which will make it easy to incorporate it in the tests here afterwards, without creating dependency cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants