From 2cfbb64ee33e2724f7675f5e1db7e610bc527f4f Mon Sep 17 00:00:00 2001
From: Jutho <jutho.haegeman@ugent.be>
Date: Wed, 4 Oct 2023 23:34:53 +0200
Subject: [PATCH] fix x86 test issues; reenable windows on github and remove
 appveyor

---
 .appveyor.yml            | 36 ------------------------------------
 .github/workflows/CI.yml |  2 +-
 test/tensors.jl          | 13 +++++++------
 3 files changed, 8 insertions(+), 43 deletions(-)
 delete mode 100644 .appveyor.yml

diff --git a/.appveyor.yml b/.appveyor.yml
deleted file mode 100644
index abbe2e06..00000000
--- a/.appveyor.yml
+++ /dev/null
@@ -1,36 +0,0 @@
-# Documentation: https://github.com/JuliaCI/Appveyor.jl
-environment:
-  matrix:
-    - julia_version: 1.6
-    - julia_version: 1.9
-    - julia_version: nightly
-platform:
-  - x64
-  - x86
-cache:
-  - '%USERPROFILE%\.julia\artifacts'
-matrix:
-  allow_failures:
-    - julia_version: nightly
-branches:
-  only:
-    - main
-    - master
-    - /release-.*/
-notifications:
-  - provider: Email
-    on_build_success: false
-    on_build_failure: false
-    on_build_status_changed: false
-install:
-  - ps: iex ((new-object net.webclient).DownloadString("https://raw.githubusercontent.com/JuliaCI/Appveyor.jl/version-1/bin/install.ps1"))
-build_script:
-  - echo "%JL_BUILD_SCRIPT%"
-  - C:\julia\bin\julia -e "%JL_BUILD_SCRIPT%"
-test_script:
-  - echo "%JL_TEST_SCRIPT%"
-  - set JULIA_NUM_THREADS=2
-  - C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"
-on_success:
-  - echo "%JL_CODECOV_SCRIPT%"
-  - C:\julia\bin\julia -e "%JL_CODECOV_SCRIPT%"
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 9b007ee7..0688718f 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -26,7 +26,7 @@ jobs:
         os:
           - ubuntu-latest
           - macOS-latest
-          # - windows-latest # run on AppVeyor instead
+          - windows-latest
         arch:
           - x64
           - x86
diff --git a/test/tensors.jl b/test/tensors.jl
index 910424d1..3d7fd3a6 100644
--- a/test/tensors.jl
+++ b/test/tensors.jl
@@ -441,14 +441,15 @@ for V in spacelist
                 t = Tensor(rand, T, V1 ⊗ V1' ⊗ V2 ⊗ V2')
                 @testset "eig and isposdef" begin
                     D, V = eigen(t, ((1, 3), (2, 4)))
-                    D̃, Ṽ = @constinferred eig(t, ((1, 3), (2, 4)))
-                    @test D ≈ D̃
-                    @test V ≈ Ṽ
-                    VdV = V' * V
-                    VdV = (VdV + VdV') / 2
-                    @test isposdef(VdV)
                     t2 = permute(t, ((1, 3), (2, 4)))
                     @test t2 * V ≈ V * D
+
+                    # Somehow moving these test before the previous one gives rise to errors
+                    # with T=Float32 on x86 platforms. Is this an OpenBLAS issue? 
+                    VdV = V' * V;
+                    VdV = (VdV + VdV') / 2
+                    @test isposdef(VdV)
+
                     @test !isposdef(t2) # unlikely for non-hermitian map
                     t2 = (t2 + t2')
                     D, V = eigen(t2)