Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for installation with Palemoon 31* (as the extension no longer works on Palemoon 29*) #69

Open
jrfnl opened this issue Jun 27, 2022 · 8 comments

Comments

@jrfnl
Copy link

jrfnl commented Jun 27, 2022

So I guess #68 was just the lead-up...

These are in my error console when loading the PR "Files" tab and the tab never actually load - spinner just keeps spinning.

SyntaxError: expected expression, got '.'[Learn More]  
vendors-node_modules_delegated-events_dist_index_js-node_modules_stacktrace-parser_dist_stack-74aed8-42898397c9f5.js:2:7624
SyntaxError: expected expression, got '.'[Learn More]  
environment-e9a18cc2906a.js:1:1909
SyntaxError: expected expression, got '.'[Learn More]  
github-elements-abe1614d4045.js:1:2185
SyntaxError: expected expression, got '.'[Learn More]  
element-registry-790f9ecbdc2d.js:1:927
SyntaxError: expected expression, got '?'[Learn More]  
vendors-node_modules_lit-html_lit-html_js-50b1c3ae31f7.js:49:2049
SyntaxError: expected expression, got '.'[Learn More]  
vendors-node_modules_github_paste-markdown_dist_index_esm_js-node_modules_github_quote-select-0221c5-f00978376043.js:22:39690
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_behaviors_pjax_ts-026aa5602248.js:1:1483
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_behaviors_keyboard-shortcuts-helper_ts-app_assets_modules_github_be-af52ef-8ba1beffba70.js:2:19
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_behaviors_details_ts-app_assets_modules_github_behaviors_include-fr-019af8-b06209b0c355.js:1:2506
SyntaxError: expected expression, got '.'[Learn More]  
behaviors-871d9186541b.js:1:1631
SyntaxError: expected expression, got '.'[Learn More]  
notifications-global-04c0dc62c5c6.js:1:10454
SyntaxError: expected expression, got '.'[Learn More]  
codespaces-754ad7f645c4.js:1:8536
SyntaxError: expected expression, got '.'[Learn More]  
vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_remote-form_-1ba5a7-12a3c067a282.js:1:9693
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_diffs_blob-lines_ts-app_assets_modules_github_diffs_linkable-line-n-f314c3-a9dc3e056a1c.js:2:933
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_fetch_ts-app_assets_modules_github_input-demux_ts-app_assets_module-e5b55c-0fa36ce63b18.js:1:10421
SyntaxError: expected expression, got '.'[Learn More]  
diffs-28dec2b5ea30.js:16:10385
SyntaxError: expected expression, got '.'[Learn More]  
scanning-3ddf75eecf81.js:3:3689
SyntaxError: expected expression, got '.'[Learn More]  
vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-6e1996-ea4d15a485fe.js:1:8464
SyntaxError: expected expression, got '.'[Learn More]  
app_assets_modules_github_command-palette_items_help-item_ts-app_assets_modules_github_comman-7e29fd-145922f171d3.js:1:5759
SyntaxError: expected expression, got '.'[Learn More]

Other symptoms:

  • emoji type ahead not working
  • Labels fold-down not filling with labels
  • Milestone fold-down not filling with available milestones
  • Individual GH Actions runs results not showing (blank black background, no steps showing)

This list is definitely not exhaustive, but just some indication.

@jrfnl
Copy link
Author

jrfnl commented Jun 27, 2022

More symptoms:

  • The fold-down to get to the "edit" button of a comment/issue doesn't show.
  • Oh and I tried to post a screenshot of the error notices, but pasting an image is also not working.

@Vangelis66
Copy link

May I ask which browser and version you're using?
Have you tried the recommended substitute of this no-longer-maintained extension?

https://github.com/martok/palefill/releases/tag/v1.14

Most of the things you cite as non-working do work here (latest Serpent 52.9.0/UXP, palefill 1.14):

gh1

gh2

(Oh, and I had no issues attaching those two screengrabs... 😜 )

@jrfnl
Copy link
Author

jrfnl commented Jun 27, 2022

@Vangelis66 Thanks for your response. I'm using Palemoon 29.1.0 on Windows. Will give the other extension a try in a moment.

For curiosity's sake: where does it say that this extension is abandoned and that the other extension is the recommended replacement ? I couldn't see anything of the kind in the Readme, nor did I see an "archived/abandoned" banner.

@jrfnl
Copy link
Author

jrfnl commented Jun 27, 2022

@Vangelis66 Okay, together with an upgrade to the latest Palemoon 31.1 (which I'd put off due to the removed support for FF/legacy extensions, which they now seem to have reversed), looks like things are working again with the extension you recommended. Thanks for your help!

@Vangelis66
Copy link

Vangelis66 commented Jun 27, 2022

I'm using Palemoon 29.1.0 on Windows.

As you've already found out yourself, that was the major cause of your predicament...
Pale Moon v29.1.0 was a quite outdated version, originally released on March 2nd 2021, that simply lacked native WebAPIs needed for the correct functioning of the github-wc-polyfill extension...

together with an upgrade to the latest Palemoon 31.1

You can also force-install this very extension there, too, if you first modify slightly its install.rdf file (which resides inside the XPI archive):

    <em:targetApplication>
      <Description>
      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
      <em:minVersion>28.14.0</em:minVersion>
-      <em:maxVersion>29.*</em:maxVersion>
+      <em:maxVersion>31.*</em:maxVersion>
      </Description>
</em:targetApplication>

where does it say that this extension is abandoned
and that the other extension is the recommended replacement ?

This extension was originally created and maintained by @JustOff, a Ukrainian citizen; after Russia's invasion of his country in late February, he said it would be quite unlikely for him to continue development of this project; on March 5th, he assigned a Chinese coder (SeaHOH) as a co-contributor and was never heard from since (I do hope he's still safe and well, BTW...).
SeaHOH did some splendid work restoring the very frequent GitHub/GitLab outages, which brought the extension to v1.2.19.

One thing he was reluctant about, though, was to enable the extension for Pale Moon 30+: #60, #66
It was inside that second issue (66) that SeaHOH made the following announcement:
#66 (comment)
which also included the recommendation to migrate over to palefill... 😉

@Vangelis66
Copy link

Vangelis66 commented Jun 27, 2022

@jrfnl:

Please, be kind enough to properly "close" this issue 😉 ; its title in particular is unnecessarily alarming (that's how I personally felt when first reading it), and, in the end, also proved to be a false claim... 😄
FTR, at this time of writing, gh-wc-polyfill-v1.2.19 still works as expected on the most-up-to-date UXP-based browsers...

(Addition: It seems that now GitHub demand that the browser natively supports both "?." and "??" 😠 ...)

@jrfnl jrfnl changed the title Here we go again: everything broken on GitHUb Allow for installation with Palemoon 31* (as the extension no longer works on Palemoon 29*) Jun 28, 2022
@jrfnl
Copy link
Author

jrfnl commented Jun 28, 2022

@Vangelis66

Please, be kind enough to properly "close" this issue 😉 ; its title in particular is unnecessarily alarming (that's how I personally felt when first reading it), and, in the end, also proved to be a false claim...

Well, closing the issue doesn't seem right as the issue isn't quite fixed as the extension doesn't allow for installation with Palemoon 31*.
I do agree that the title can be made less alarming and more specific and actionable, now the immediate problem is gone and the root cause is known (and I have done so).

And yes, I'm well aware that Palemoon 29.1.* was ancient, but it was the last version to officially support legacy extensions (before the recent turn-around), which was crucial to me.

This extension was originally created and maintained...

Thank you for that background information and the links and I join you in hoping that @JustOff is safe! I'd also like to thank @JustOff and @SeaHOH for all their work on this extension, which has been a must-have for my daily work for the past few years.

@Vangelis66
Copy link

... the issue isn't quite fixed
as the extension doesn't allow for installation with Palemoon 31.
[snipped]
(and I have done so)

Thanks for modifying the issue title 👍 ; now this issue is just a duplicate of #66 (and this reflects better the truth! 😉 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants