Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test #3

Open
GrimTheReaper opened this issue Apr 12, 2019 · 1 comment
Open

Add Test #3

GrimTheReaper opened this issue Apr 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@GrimTheReaper
Copy link
Member

I'm thinking we try to test this against the major SQL DBs, such as Oracle, MySQL, Postgress (probably not needed since they have a pretty snazzy client), MsSQL/TSQL/SQLServer, and whatever else that I am probably forgetting.

I would like to employ docker to do this, as it would make spinning up test environments and actually testing our functionally reasonable.
@GrimTheReaper GrimTheReaper added the enhancement New feature or request label Apr 12, 2019
@IngCr3at1on
Copy link
Member

IngCr3at1on commented Apr 12, 2019 •
edited
Loading

Consider doing tests in 2 phases:

  1. package level logic tests for individual functions (DB interactions can be handled over https://github.com/DATA-DOG/go-sqlmock
  2. integration tests at the external level <pkg>_test using live databases in docker-compose.

This should allow you to keep a smooth developer experience with the unit tests while still having your full "real world" coverage at the integration level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IngCr3at1on @GrimTheReaper