Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unsorted arguments by default #44

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Conversation

0x0f0f0f
Copy link
Member

As discussed in call

Alessandro Cheli and others added 2 commits June 18, 2024 22:04
@0x0f0f0f
Copy link
Member Author

@ChrisRackauckas

Project.toml Outdated Show resolved Hide resolved
@0x0f0f0f
Copy link
Member Author

Should we also define sorted_children and default children to be unsorted? @YingboMa @ChrisRackauckas

@ChrisRackauckas
Copy link
Member

I'd say yes, @YingboMa ?

@YingboMa
Copy link
Member

Yeah, I think so too.

@0x0f0f0f
Copy link
Member Author

Will push by tonight.

@0x0f0f0f
Copy link
Member Author

@ChrisRackauckas @YingboMa ready for final review

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on @YingboMa 's opinion now.

@ChrisRackauckas ChrisRackauckas merged commit 568ef13 into master Jun 23, 2024
7 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ale/sorted-arguments branch June 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants