Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs update for string.data changes #27

Open
stevengj opened this issue Jan 4, 2017 · 1 comment
Open

needs update for string.data changes #27

stevengj opened this issue Jan 4, 2017 · 1 comment

Comments

@stevengj
Copy link
Member

stevengj commented Jan 4, 2017

After JuliaLang/julia#19449, soon to be merged for Julia 0.6, you will no longer be able to access the raw bytes of a string via string.data; instead, do Vector{UInt8}(string). For example, this affects:

https://github.com/nolta/ICU.jl/blob/cbc2d74e020d4f7935498d52bbbffb3a98cce6d0/src/ICU.jl#L166

@stevengj
Copy link
Member Author

stevengj commented Jan 4, 2017

Note that in that line you can just pass str, sizeof(str) instead of str.data, sizeof(str.data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant