Update CUTEst.jl for CUTEst v2.3.0 #423
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
===========================================
- Coverage 89.11% 74.18% -14.94%
===========================================
Files 5 7 +2
Lines 790 1654 +864
===========================================
+ Hits 704 1227 +523
- Misses 86 427 +341 ☔ View full report in Codecov by Sentry. |
amontoison
merged commit 1f0639d
into
JuliaSmoothOptimizers:main
| # class = Vector{Cchar}(undef, 30) | ||
| # CUTEst.classification(T, nlp.libsif, nlp.status, nlp.funit, class) |
There was a problem hiding this comment.
What was wrong here @amontoison ? As the function is no longer tested it seems
There was a problem hiding this comment.
Nick added this routine with the release 2.3.0 but I have some issue to make it work in Julia.
I think that Fortran changes the Julia pointer and it leads to a seg fault but we can't do that.
Julia own the memory.
With this new release of CUTEst, we also added a C version for all routines with string (name) and it means that strring are null-terminated (Ptr{Cchar} -> Cstring).
If I find time, I would like to update all api related to routine with string.
There was a problem hiding this comment.
Oki, thanks! Could you make an issue for that?
There was a problem hiding this comment.
Let's wait that all the C tests in CUTEst passed first:
ralna/CUTEst#67
No description provided.