draft MvNormal #122
Draft
draft MvNormal #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What do you think of going the way of GaussianDistributions.jl and have one object for 1d and nd Gaussians? |
|
It's an interesting idea, my only concerns would be
Then again, I've strayed a little from Distributions's naming already; |
|
|
|
|
|
|
|
|
|
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 33.96% 36.46% +2.49%
==========================================
Files 50 45 -5
Lines 998 883 -115
==========================================
- Hits 339 322 -17
+ Misses 659 561 -98
Continue to review full report at Codecov.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.