Add implicitly mapped measures and kernels #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 54.17% 56.32% +2.14%
==========================================
Files 42 44 +2
Lines 1209 1321 +112
==========================================
+ Hits 655 744 +89
- Misses 554 577 +23 ☔ View full report in Codecov by Sentry. |
oschulz
force-pushed
the
implicit-maps
branch
from
44cd0b1
to
06e802a
Compare
cscherrer
reviewed
Nov 3, 2024
cscherrer
reviewed
Nov 3, 2024
cscherrer
reviewed
Nov 3, 2024
cscherrer
reviewed
Nov 3, 2024
oschulz
force-pushed
the
implicit-maps
branch
2 times, most recently
from
d6fe43e
to
e5b8af3
Compare
|
Rebased PR, moved reformats into topical commit for better history, no change in total diff. |
oschulz
force-pushed
the
implicit-maps
branch
3 times, most recently
from
5e51e56
to
c2ed86a
Compare
|
Require Julia v1.10 and added ChainRulesCore extension, so new rrules in this PR can go into the right place directly. |
oschulz
force-pushed
the
implicit-maps
branch
2 times, most recently
from
113196a
to
500ed55
Compare
Closed
|
|
Yay, tests all green now. :-) |
oschulz
force-pushed
the
implicit-maps
branch
from
500ed55
to
9add372
Compare
|
oschulz
force-pushed
the
implicit-maps
branch
from
9add372
to
f069d4a
Compare
|
|
oschulz
force-pushed
the
implicit-maps
branch
from
6463b3c
to
d99966b
Compare
|
|
|
|
cscherrer
approved these changes
Nov 4, 2024
|
While the load time of StaticArrays is rather high, be we can't take advantage of statically known measure sizes without a direct dependency on it. With StaticArrays we'll be able to handle many low-dimension problems without any heap allocations in the future.
PropertyFunctions provides a good base to handle marginalization.
We need maximum performance for these.
We need maximum performance on these. Also try to preserve floating point types as far as possible.
Improves type stability and numerical type propagation. Specialize logdensityof until a full refactor of the density engine.
Rename TransformVolCorr and subtypes (with backward compatibility).
Ensures proper type propagation (until future refactor of density calculation engine).
oschulz
force-pushed
the
implicit-maps
branch
from
ee59a9e
to
3304a4e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
logdensityoffor primitve, standard and combinator measures.