Skip to content

Commit

Permalink
Julia v1.11 Support (#66)
Browse files Browse the repository at this point in the history 
* Julia v1.11 Support

* Fix checksingular
  • Loading branch information
@dlfivefifty
dlfivefifty authored Aug 6, 2024
1 parent bbaf308 commit d3f30bb
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
version:
- '1.9'
- '1'
- '^1.11.0-0'
os:
- ubuntu-latest
- macOS-latest
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "MatrixFactorizations"
uuid = "a3b82374-2e81-5b9e-98ce-41277c0e4c87"
version = "3.0.0"
version = "3.0.1"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
4 changes: 3 additions & 1 deletion src/ul.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ end

if VERSION < v"1.7-"
_checknonsingular(info, ::Val{Pivot}) where Pivot = checknonsingular(info, Val{Pivot}())
else
elseif VERSION < v"1.11-"
_checknonsingular(info, ::Val{true}) = checknonsingular(info, RowMaximum())
_checknonsingular(info, ::Val{false}) = checknonsingular(info, NoPivot())
else
_checknonsingular(info, _) = checknonsingular(info)
end

"""
Expand Down
15 changes: 11 additions & 4 deletions test/test_ul.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,17 @@ using LinearAlgebra: ldiv!, BlasReal, BlasInt, BlasFloat, rdiv!
@test_throws SingularException ul!(copy(A); check = true)
@test !issuccess(ul(A; check = false))
@test !issuccess(ul!(copy(A); check = false))
@test_throws ZeroPivotException ul(A, Val(false))
@test_throws ZeroPivotException ul!(copy(A), Val(false))
@test_throws ZeroPivotException ul(A, Val(false); check = true)
@test_throws ZeroPivotException ul!(copy(A), Val(false); check = true)
if VERSION < v"1.11-"
@test_throws ZeroPivotException ul(A, Val(false))
@test_throws ZeroPivotException ul!(copy(A), Val(false))
@test_throws ZeroPivotException ul(A, Val(false); check = true)
@test_throws ZeroPivotException ul!(copy(A), Val(false); check = true)
else
@test_throws SingularException ul(A, Val(false))
@test_throws SingularException ul!(copy(A), Val(false))
@test_throws SingularException ul(A, Val(false); check = true)
@test_throws SingularException ul!(copy(A), Val(false); check = true)
end
@test !issuccess(ul(A, Val(false); check = false))
@test !issuccess(ul!(copy(A), Val(false); check = false))
F = ul(A; check = false)
Expand Down

2 comments on commit d3f30bb

@dlfivefifty
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/112491

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v3.0.1 -m "<description of version>" d3f30bb62fc282e9a3873a858f2823339888e143
git push origin v3.0.1

Please sign in to comment.